Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Use fixed width for icons in the backend #28670

Open
coolcat-creations opened this issue Apr 12, 2020 · 9 comments
Open

[4.0] Use fixed width for icons in the backend #28670

coolcat-creations opened this issue Apr 12, 2020 · 9 comments

Comments

@coolcat-creations
Copy link
Contributor

What needs to be fixed

grafik

grafik

The Icons in front of the titles use a different width. For a constant and harmonic look it would be great to have a fixed width for the icons in front.

@brianteeman
Copy link
Contributor

all you have to do is to add the class fa-fw to all the icons. easy enough for you to do and submit a pr

@coolcat-creations
Copy link
Contributor Author

coolcat-creations commented Apr 12, 2020

@brianteeman I am not sure if that fixes the issue for 3rd party icons since they are not Font Awesome Icons. That's why I also posted the screen with the patch tester.

@coolcat-creations coolcat-creations changed the title [4.0] Use fixed width for icons in the backen [4.0] Use fixed width for icons in the backend Apr 12, 2020
@brianteeman
Copy link
Contributor

It doesnt but it is the starting point

@C-Lodder
Copy link
Member

I don't see this as an issue personally. Icons will never be the same with. Fixed with are normally used in things like list items....where each item comes directly below each other. Seeing as these are cards and scattered around the dashboard, I don't see the need for a fixed width.

@chmst
Copy link
Contributor

chmst commented Apr 13, 2020

Agree with @C-Lodder. I think it is not possible to define a width, as icons can be changed by the user. If we have a fixed width, individual icons must be cut. Or, if they are very small, we would have a lot of free space.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28670.

@coolcat-creations
Copy link
Contributor Author

Hm, I would rather see a restriction in size here otherwise extensions can break the UI completely. There is a reason why for example a apple touch icon must have a specific size otherwise the screen would look cluttered in the extensions settings overview or whereever.

@brianteeman
Copy link
Contributor

If an extension looks bad it wont be long before the extension developer fixes it

@Chaosxmk
Copy link

If a fixed width is an issue, would a min-width work better? It would at least be a more flexible option.

@brianteeman
Copy link
Contributor

I guess nothing is going to happen here now and this should be closed. Not my call though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants