New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Template Atum - Usage and names of the Joomla Logo and Custom Logo #28826
Comments
Since you're at it, the Joomla logo is now visible as "Jooma". The SVG that was produced for the logo is surely not optimal. Here's how it looks on today's build from commit with ID: https://github.com/joomla/joomla-cms/tree/08b27e74737f859c6a873c661df268ca4a7f148b |
Disregard my previous comment as it was a stuck cached copy showing up from before the update to today's snapshot. Still, it could use some really minor spacing between the letters (which would require a different SVG file altogether), if it's to display at such a small size OR it should be bumped from 1.3 to something like 1.8 rems. For example: |
@fevangelou Thank you! Well, I will not be able to change the registered Joomla Logo but I'll see how to fix the Dimensions to make it appear better :-) |
Closed because of the PR #28839 |
What needs to be fixed
We have currently in template Atum the different logos:
logo-joomla-white.svg
logo-joomla-blue.svg
logo-blue.svg
logo.svg
login.php
error_full.php
index.php
error_login.php
But for examplate it's defined in index.php but not apparently not used there.
Then there is the logo-blue.svg which is used in login.php in a different size as in index.php.
where logo-blue is the Joomla brandmark and logo-joomla-blue.svg is the full logo.
The naming ist not logical and the usage of the logos is confusing, The logos need renaming, research where what is used and cleaned up. The names should be more general and contain their usage. For example something like logo-login-form.svg logo-header-collapsed.svg, logo-header-expanded.svg ... and so on. Since they can be coloured they don't have to contain a color name, since they can be changed after a template copy they should not contain "joomla" in it's file name.
The usage of a custom logo in the template stile has to be corrected like reported by @micker
The size of the svg should be defined in the svg itself and not in the scss like reported by @C-Lodder
I can work on this issue just dropping it in here as an issue to have a worklist-item.
The text was updated successfully, but these errors were encountered: