Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] HTMLHelper TabSet set active Tab did not work #28951

Closed
HRIT-Florian opened this issue May 5, 2020 · 4 comments
Closed

[4.0] HTMLHelper TabSet set active Tab did not work #28951

HRIT-Florian opened this issue May 5, 2020 · 4 comments

Comments

@HRIT-Florian
Copy link
Contributor

Steps to reproduce the issue

administrator\components\com_content\tmpl\article\edit.php
Edit
<?php echo HTMLHelper::_('uitab.startTabSet', 'myTab', array('active' => 'gernal')); ?>
To
<?php echo HTMLHelper::_('uitab.startTabSet', 'myTab', array('active' => 'images')); ?>

Expected result

Images Tab should be activ

Actual result

First Tab is active

System information (as much as possible)

PHP Version | 7.3.14
Joomla! 4.0.0-beta1-dev Development [ Mañana ] 17-October-2019 20:21 GMT
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

@SharkyKZ
Copy link
Contributor

SharkyKZ commented May 5, 2020

Tabs use sessionStorage to remember last opened tab. This is stored for each URL. Try editing a different article and it should go straight to image tab.

@C-Lodder
Copy link
Member

C-Lodder commented May 5, 2020

@SharkyKZ Yes, but that's if a tab is clicked. This issue is regarding activating a specific tab

@HRIT-Florian
Copy link
Contributor Author

HRIT-Florian commented May 6, 2020

@SharkyKZ Yes, right. I would suggest for UX, these should not be affected when a specific Tab is dynamic activated. In my case I used these for dynamic set a Tab by input like these:

<?php echo HTMLHelper::_('uitab.startTabSet', 'myTab', array('active' => $inputTab)); ?>

@joomdonation
Copy link
Contributor

I just tried it again and it worked on latest Joomla 4 (I use this kind of code in my own extensions, too). So look like it was solved elsewhere. For now, I'm closing this issue. Feel free to re-open it if you can still re-procedure it with latest Joomla 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants