Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Category.php #28968

Closed
wants to merge 1 commit into from
Closed

Conversation

artur-stepien
Copy link
Contributor

@artur-stepien artur-stepien commented May 6, 2020

Summary of Changes

Allow same category alias in the same parent category and extension when there is a different language selected.

Testing Instructions

  • Install additional language (eg pl-PL)
  • Got to Content -> Categories
  • Create a category with the name Test, select the language to en-GB
  • Try to create another category with the name Test and alias set to test but with a different language (eg pl-PL) and set the parent to same parent as the category above.

Expected result

  • Ability to have the same alias for categories in a different language but same root category

Actual result

  • Save fails

Documentation Changes Required

None

Allow same alias in same parent and extension when there is a different language selected.
@SharkyKZ
Copy link
Contributor

SharkyKZ commented May 6, 2020

I think this is not allowed on purpose. If you disable Language Filter, one of the categories won't be accessible due to conflicting aliases. Same applies to other content types.

@artur-stepien
Copy link
Contributor Author

That's a good point and its something to discuss I think.

Pros:

  • Ability to have same alias for multiple languages (mostly for a root category)

Cons:

  • Issue with duplicated aliases when user disables language filter for some reason while having same alias in multiple languages in same parent category

Anything more you could think of (both pros and cons)?

@infograf768
Copy link
Member

It is indeed not allowed on purpose.
A good setting for a multilingual site is to always set a root parent category per language for each component.
I guess we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants