Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix filtering banners by keywords #29486

Merged
merged 2 commits into from Jun 12, 2020
Merged

[4.0] Fix filtering banners by keywords #29486

merged 2 commits into from Jun 12, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Jun 8, 2020

Summary of Changes

Fixes filtering banners by keywords. Similar to #29466.

Testing Instructions

Create a banner client.
Create a banner. Assign to a client. Add a keyword, e.g. Joomla.
Set some keywords for the document. Make sure the last keyword is not the same as the one set in the banner. E.g. add this to templates/cassiopeia/index.php:

$this->setMetadata('keywords', 'Joomla, CMS');

Publish a banner module. Enable Select by Keyword option.
View the module in frontend.

Expected result

Banner shown.

Actual result

Banner not shown.

Documentation Changes Required

@ChristineWk
Copy link

ChristineWk commented Jun 12, 2020

banner
Was not sure where to add,
So, added above line (Instructions) templates/cassiopeia/index.php: to this place:
$app = Factory::getApplication();
$lang = $app->getLanguage();
$wa = $this->getWebAssetManager();
$this->setMetadata('keywords', 'Joomla, CMS');

@ChristineWk
Copy link

I have tested this item ✅ successfully on 1c6a570


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29486.

@wilsonge wilsonge merged commit f421912 into joomla:4.0-dev Jun 12, 2020
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 12, 2020
@SharkyKZ SharkyKZ deleted the j4/query/banners branch June 13, 2020 08:54
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants