Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JHtml underscore method #29635

Merged
merged 2 commits into from Jun 16, 2020
Merged

Use JHtml underscore method #29635

merged 2 commits into from Jun 16, 2020

Conversation

SharkyKZ
Copy link
Contributor

Summary of Changes

Use JHtml::_() instead of using JHtml classes directly to allow overrides.

Testing Instructions

Code review.

Documentation Changes Required

No.

@ChristineWk
Copy link

I have tested this item ✅ successfully on c4e94fd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29635.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 16, 2020

I have tested this item ✅ successfully on c4e94fd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29635.

@Quy
Copy link
Contributor

Quy commented Jun 16, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29635.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 16, 2020
@wilsonge wilsonge merged commit 6e82cca into joomla:staging Jun 16, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 16, 2020
@wilsonge wilsonge added this to the Joomla! 3.9.20 milestone Jun 16, 2020
@SharkyKZ SharkyKZ deleted the j3/cleanup/html branch June 16, 2020 17:14
Reconix pushed a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants