Missing preview icon

[N6REJ]

Pull Request for Issue # .

Summary of Changes

repaired preview icon lost in last pr

Testing Instructions

go to System > Site Templates > Cassiopeia Details and Files > Template Preview button and verify the image icon "fas fa-image" is there

Actual result BEFORE applying this Pull Request

no icon present

Expected result AFTER applying this Pull Request

Documentation Changes Required

none

[sandewt]

I have tested this item ✅ successfully on 59c1ab8

Result:

<span class="fas fa-image" aria-hidden="true"></span>

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30242.}

[infograf768]

I have tested this item ✅ successfully on 59c1ab8

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30242.}

[infograf768]

Restarted drone.
Note: Looks I forgot to add that preview button for admin templates.

[sandewt]

Restarted drone.

What do you mean?

Note: Looks I forgot to add that preview button for admin templates.

Right, it will link to the site instead of seeing a preview of the template.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30242.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30242.}

[infograf768]

@N6REJ
Could you please update your branch from origin to solve the drone issue?

Also, as you are at it, I suggest you add the Preview button for admin template.
The whole block of code should be

		// Add a Template preview button
		$client = (int) $this->preview->client_id === 1 ? 'administrator/' : '';

		if ($this->type === 'home')
		{
			$bar->linkButton('preview')
				->icon('fas fa-image')
				->text('COM_TEMPLATES_BUTTON_PREVIEW')
				->url(Uri::root() . $client . 'index.php?tp=1&templateStyle=' . $this->preview->id)
				->attributes(['target' => '_new']);
		}

I tested it fine. I can also do in a new PR if you prefer.

[N6REJ]

@N6REJ
Could you please update your branch from origin to solve the drone issue?

Also, as you are at it, I suggest you add the Preview button for admin template.

I tested it fine. I can also do in a new PR if you prefer.

done

However the preview buttons doesn't work correctly.
It takes you back to dashboard via /administrator/index.php?tp=1&templateStyle=10
but thats for another pr

[infograf768]

However the preview buttons doesn't work correctly.
It takes you back to dashboard via /administrator/index.php?tp=1&templateStyle=10

It does not take you back but opens a new window with modules positions.
That is perfectly fine imho.

Relaunched drone again.