Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0][WIP][RFC] Child templates part 2: com_templates #30359

Closed
wants to merge 4 commits into from
Closed

[4.0][WIP][RFC] Child templates part 2: com_templates #30359

wants to merge 4 commits into from

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This is still work in progress read the comments bellow

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@dgrammatiko
Init
ad9e909
@dgrammatiko
Merge branch '4.0-dev' of github.com:joomla/joomla-cms into 4.0-dev-c…
77aa39b 
…om_templates

* '4.0-dev' of github.com:joomla/joomla-cms:
  Add closing quote (joomla#30353)
  [4.0] Make sure the renderer does not manipulate the inline CSS and JS (joomla#28719)
  [4.0] Atum and Cassiopea Change alerts styling - space saving + (joomla#30294)
  Update editor versions (joomla#30340)
  [4.0][mod_menu] Add space for 'menu class' (joomla#30341)
  Optimize code for aria-current (joomla#30328)
  [4.0] Composer and npm updates 10 Aug (joomla#30334)
  [4.0] fix js code style (joomla#30335)
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev RFC Request for Comment labels Aug 13, 2020
@dgrammatiko
Copy link
Contributor Author

So, as I promised I am going to work on finalising the child templates proposal.
The approach here is the one that was proposed by @Fedik #30149 (comment)

Move button "Create Child" to a template style form, and rename to "Override template files" (or something similar)

Screenshot 2020-08-13 at 12 03 24

This "new template" should not be visible in "templates list", only via template style. (this need to avoid confusing between all these template things)

Screenshot 2020-08-13 at 12 04 34

So far this PR is based on mild changes on the current workflow of com_templates and if this is what people are ok then the code should be ready in the coming days for testing. But since I'm spending some time reworking basically most parts of the component a better workflow, more intuitive could be a better approach here. Let me explain:

  • right now we have 2 list views (templates & styles) that in the component level are not really connected
  • we could merge these 2 list views in one and have a list of the templates (as is right now) with an additional accordion like component so when someone clicks on the template the styles are revealed (and clicking on a style the toolbar reveals the appropriate buttons)
  • also there was some work already done by @kawshar 's team which maybe a good idea to bring it in (I mean if they're ok with it)

Anyways, suggestions, ideas, feedback is welcome here...

@kawshar
Copy link

kawshar commented Aug 13, 2020 •
edited

You are welcome to adopt anything from our concept. For Joomla :)

About the multiple views, we can easily merge both without breaking anything.

@brianteeman
Copy link
Contributor

Definitely in favour of merging the template views.

@dgrammatiko @brianteeman
Update administrator/language/en-GB/com_templates.ini
fc65b9f 
Co-authored-by: Brian Teeman <brian@teeman.net>
@dgrammatiko
Copy link
Contributor Author

Definitely in favour of merging the template views.

Just a comment here about merging the 2 views together: there are quite some issues that need to be addressed:

  • Extremely hard to get thee filters working with both the templates and their styles
  • The toolbar might need a bit of custom code to follow selections (template/style)
  • pagination
  • probably a few more that I can't even think about right now

That said combining the views is really not that hard (code wise) but we need at least for the first step some sort of design, eg and unstyled, not really functional page was just few lines:
Aug-14-2020 14-51-24

@SharkyKZ SharkyKZ mentioned this pull request Aug 24, 2020
Merged
@dgrammatiko dgrammatiko mentioned this pull request Oct 24, 2020
Closed
@dgrammatiko dgrammatiko mentioned this pull request Nov 5, 2020
Closed
@dgrammatiko dgrammatiko mentioned this pull request Feb 13, 2021
Closed
@dgrammatiko
Copy link
Contributor Author

moving to #32896

@dgrammatiko dgrammatiko closed this Apr 1, 2021
@dgrammatiko dgrammatiko deleted the 4.0-dev-com_templates branch April 7, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianteeman brianteeman brianteeman left review comments

Assignees
No one assigned
Labels
Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester RFC Request for Comment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dgrammatiko @kawshar @brianteeman @joomla-cms-bot