Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix debuguser/debuggroup icon color #30414

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

infograf768
Copy link
Member

Same issue as #30411

Summary of Changes

Icon class fas fa-times needs text-danger color. Otherwise it displays as white on white/lightgrey

Testing Instructions

Click on Permissions column icon to get the debug manager for a specififc user.
Same for a specific group.

Actual result BEFORE applying this Pull Request

User

Screen Shot 2020-08-19 at 09 01 38

Group

group_times

Expected result AFTER applying this Pull Request

User

Screen Shot 2020-08-19 at 09 03 20

Group

Screen Shot 2020-08-19 at 09 04 05

@infograf768
Copy link
Member Author

Note

Do we really need the $button variable?
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_users/tmpl/debuggroup/default.php#L62-L85

						<?php foreach ($this->actions as $action) : ?>
								<?php
								$name  = $action[0];
								$check = $item->checks[$name];
								if ($check === true) :
									$class  = 'text-success fas fa-check';
									$button = 'btn-success';
									$text   = Text::_('COM_USERS_DEBUG_EXPLICIT_ALLOW');
								elseif ($check === false) :
									$class  = 'text-danger fas fa-times';
									$button = 'btn-danger';
									$text   = Text::_('COM_USERS_DEBUG_EXPLICIT_DENY');
								elseif ($check === null) :
									$class  = 'text-danger fas fa-minus-circle';
									$button = 'btn-warning';
									$text   = Text::_('COM_USERS_DEBUG_IMPLICIT_DENY');
								else :
									$class  = '';
									$button = '';
									$text   = '';
								endif;
								?>
							<td class="text-center">
								<span class="<?php echo $class; ?>" aria-hidden="true"></span>
								<span class="sr-only"> <?php echo $text; ?></span>
							</td>

@ceford
Copy link
Contributor

ceford commented Aug 19, 2020

I have tested this item ✅ successfully on b6da810

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30414.

@Magnytu2
Copy link

Works fine for me.

@infograf768
Copy link
Member Author

Please mark your test ok at https://issues.joomla.org/tracker/joomla-cms/30414

@Magnytu2
Copy link

I have tested this item ✅ successfully on b6da810

Works fine for me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30414.

@infograf768
Copy link
Member Author

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30414.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 19, 2020
@infograf768 infograf768 added this to the Joomla 4.0 milestone Aug 19, 2020
@Quy Quy added the PR-4.0-dev label Aug 19, 2020
@Quy Quy merged commit 5e0f286 into joomla:4.0-dev Aug 19, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 19, 2020
@Quy
Copy link
Contributor

Quy commented Aug 19, 2020

$button can be removed. Thanks.

@infograf768 infograf768 deleted the 4.0_debuguser_icons_color branch August 19, 2020 18:43
@infograf768
Copy link
Member Author

$button can be removed. Thanks.

For another pr. looks like it is also useless in 3.x

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants