New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix token check when removing data via privacy removal request #30479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fixing the problem, thanks! Will it be available in the next version? |
I have tested this item ✅ successfully on 20d0e3e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30479. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30479. |
Merging thanks |
Reconix
pushed a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
…a#30479) * Fix token check * Use nice token check
Reconix
added a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
joomla#30479)" This reverts commit 2b14692.
Reconix
added a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
joomla#30479)" This reverts commit 2b14692.
Reconix
added a commit
to Reconix/joomla-cms
that referenced
this pull request
Aug 31, 2020
…l request (joomla#30479)"" This reverts commit 4dfa807.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30478.
Summary of Changes
Fixes removing user data from request view.
Testing Instructions
Create a data removal request and confirm it.
Open the request in backend.
Click
Delete Data
button in toolbar.Actual result BEFORE applying this Pull Request
White page with text:
Expected result AFTER applying this Pull Request
Data removed.
Documentation Changes Required
No.