Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token check when removing data via privacy removal request #30479

Merged
merged 2 commits into from Aug 31, 2020
Merged

Fix token check when removing data via privacy removal request #30479

merged 2 commits into from Aug 31, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Aug 25, 2020

Fixes #30478.

Summary of Changes

Fixes removing user data from request view.

Testing Instructions

Create a data removal request and confirm it.
Open the request in backend.
Click Delete Data button in toolbar.

Actual result BEFORE applying this Pull Request

White page with text:

The most recent request was denied because it had an invalid security token. Please refresh the page and try again.

Expected result AFTER applying this Pull Request

Data removed.

Documentation Changes Required

No.

@ldemirova
Copy link

ldemirova commented Aug 26, 2020

This is fixing the problem, thanks! Will it be available in the next version?

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 20d0e3e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30479.

@Quy
Copy link
Contributor

Quy commented Aug 26, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30479.

@Quy Quy removed the PR-staging label Aug 26, 2020
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 26, 2020
@Quy Quy added the PR-staging label Aug 26, 2020
@zero-24 zero-24 added this to the Joomla! 3.9.22 milestone Aug 31, 2020
@zero-24
Copy link
Contributor

zero-24 commented Aug 31, 2020

Merging thanks

@zero-24 zero-24 merged commit 4546b39 into joomla:staging Aug 31, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 31, 2020
@SharkyKZ SharkyKZ deleted the j3/fix/privacy-token-check branch August 31, 2020 15:58
Reconix pushed a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Reconix added a commit to Reconix/joomla-cms that referenced this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not delete data via privacy removal request due to missing CSRF token
6 participants