[31506] Solved performance issue with zip archives containing zip files #31514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on cfe695b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31514. |
|
I have tested this also ✅ successfully |
|
I have tested this item ✅ successfully on cfe695b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31514. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31514. |
|
Drone errors not related to this PR. |
|
Thanks |
joomla-cms-bot
added
Composer Dependency Changed
and removed
RTC
|
This should be added as a note here: https://docs.joomla.org/Category:Version_3.9.23_FAQ |
|
Hi Brad. 😄 |
I don't talk, but I am still around 👍 |
This was referenced Dec 16, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #31506.
Summary of Changes
For zip files, load the buffer directly instead of utilising the stream.
Testing Instructions
Install an extension that contains zip files in the zip archive without increasing the max execution time..
Actual result BEFORE applying this Pull Request
You'll get an error like
Gateway Timeout - The gateway did not receive a timely response from the upstream server or application.
because of the timeout.
Expected result AFTER applying this Pull Request
Installation works as it should.
Documentation Changes Required
No.