Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Joomla.sql #3185

Closed
wants to merge 1 commit into from
Closed

Update Joomla.sql #3185

wants to merge 1 commit into from

Conversation

RustyIngles
Copy link

Added missing updates table to lines 1750 - 1766, which solves the update issue.

Added missing updates table to lines 1750 - 1766, which solves the update issue.
@Bakual
Copy link
Contributor

Bakual commented Feb 26, 2014

@RustyIngles Thanks for your PR. Since we are still tracking bugs in our JoomlaCode tracker, may I ask you to open an item there and reference it back here?
And can you also add some notes about which exact issue you mean?

@Hackwar
Copy link
Member

Hackwar commented Mar 2, 2014

What exactly are you trying to solve how? Quoting the default values is okay, not exactly necessary, but the auto increment should be handled automatically by the DB and not be part of the scheme definition in my opinion. As far as I can see, the change from varchar to text is the only real change, right? Could we limit the PR to that then?

@phproberto
Copy link
Contributor

👎 This will cause issues so be sure to not merge it in the current state.

@brianteeman
Copy link
Contributor

Is this still valid?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3185.

@nicksavov
Copy link
Contributor

Looks like there are merge conflicts too. I'm going to go ahead and close this PR. Could you update to the latest staging and submit a new PR? Within the PR please give some clarification on what you're hoping to achieve, as well as testing instructions.

Thanks!

@nicksavov nicksavov closed this Oct 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants