Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Removing three strings which are not supposed to be translated. #32160

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Jan 25, 2021

#31379 introduced three new language strings. But the strings are technical terms which are not supposed to be translated:

COM_CONFIG_FIELD_WEBSERVICES_CORS_ALLOW_ORIGIN_LABEL="Access-Control-Allow-Origin"
COM_CONFIG_FIELD_WEBSERVICES_CORS_ALLOW_HEADERS_LABEL="Access-Control-Allow-Headers"
COM_CONFIG_FIELD_WEBSERVICES_CORS_ALLOW_METHODS_LABEL="Access-Control-Allow-Methods"

Summary of Changes

This PR removes the strings and "hardcodes" the label to the term. It also adjusts the form XML so it doesn't try to translate the string.

Testing Instructions

Go to global configuration -> server tab. Enable "CORS" and then check the labels of the three "Access-Control-Allow-..." parameters

Actual result BEFORE applying this Pull Request

Strings are translated to the technical term

Expected result AFTER applying this Pull Request

Strings are not translated.
But actually no difference to before the PR.

Documentation Changes Required

None

@brianteeman
Copy link
Contributor

LGTM

@wilsonge wilsonge merged commit c9f783b into joomla:4.0-dev Jan 25, 2021
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jan 25, 2021
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jan 25, 2021
@zero-24
Copy link
Contributor

zero-24 commented Jan 25, 2021

Why not use that string to add documentation (link to Mozilla docs) that would explain that technical term similiar how we did in with com_csp?

For the translators we can place a comment asking them not to translate that string.

@Bakual Bakual deleted the 4_RemoveUselessStrings branch January 25, 2021 21:58
@Bakual
Copy link
Contributor Author

Bakual commented Jan 25, 2021

It's the label of the parameter. There is still a translated description where such things could be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants