Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Skipto RTL #32463

Merged
merged 2 commits into from
Feb 23, 2021
Merged

[4.0] Skipto RTL #32463

merged 2 commits into from
Feb 23, 2021

Conversation

brianteeman
Copy link
Contributor

Updates the RTL override for the skipto plugin to prevent a bug where 3000em were added to the left of the template.

Hopefully this will be fixed upstream eventually and this can be removed then

@ceford I think you observed this bug before

Updates the RTL override for the skipto plugin to prevent a bug where 3000em were added to the left of the template.

Hopefully this will be fixed upstream eventually and this can be removed then
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Feb 19, 2021
@ceford
Copy link
Contributor

ceford commented Feb 20, 2021

I have tested this item ✅ successfully on e3ff5a9

My Test: make Iranian the default site language. Reload the Home page and press the tab key to invoke the Skip to menu. Without the patch there is a huge space to the left and the page autoscrolls left on skipto menu hover. With the patch it works normally.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32463.

@infograf768
Copy link
Member

I can't reproduce the issue on Firefox here.
On which browsers/OS should this be tested?

@infograf768
Copy link
Member

Ah. I think I found out: here it happens after displaying the dropdown and NOT using it, i.e. click on the page.
testing now.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on e3ff5a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32463.

@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32463.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2021
@infograf768 infograf768 added this to the Joomla 4.0 milestone Feb 22, 2021
@infograf768 infograf768 merged commit ee5900f into joomla:4.0-dev Feb 23, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 23, 2021
@infograf768
Copy link
Member

Tks

@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the skiptortl branch February 23, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants