-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Remove .bg-white #32877
Merged
Merged
[4.0] Remove .bg-white #32877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on 5abcc46 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877. |
You should also look at other uses of bg-white and review if they are needed |
@brianteeman This is the only instance. |
|
joomla-cms-bot
added
the
NPM Resource Changed
This Pull Request can't be tested by Patchtester
label
Mar 26, 2021
Thanks. Please retest. |
I have tested this item ✅ successfully on c851260 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877. |
1 similar comment
I have tested this item ✅ successfully on c851260 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877. |
Quy
removed
the
NPM Resource Changed
This Pull Request can't be tested by Patchtester
label
Mar 26, 2021
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877. |
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
and removed
RTC
This Pull Request is Ready To Commit
labels
Mar 27, 2021
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The background color is already white. No need to add .bg-white which affects dark themes.
For the subhead, it has the white background, thus, no need to add .bg-white.
Testing Instructions
Code review.
or
Add/Edit an article.
npm run build:js
Switch to Atum.
Scroll up to display the subhead in Atum as before.