Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remove .bg-white #32877

Merged
merged 2 commits into from
Mar 27, 2021
Merged

[4.0] Remove .bg-white #32877

merged 2 commits into from
Mar 27, 2021

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Mar 26, 2021

Summary of Changes

The background color is already white. No need to add .bg-white which affects dark themes.

For the subhead, it has the white background, thus, no need to add .bg-white.

Testing Instructions

Code review.

or

  1. Install a dark theme: https://github.com/C-Lodder/joomla4-backend-template
    Add/Edit an article.

bg-white

  1. Run npm run build:js
    Switch to Atum.
    Scroll up to display the subhead in Atum as before.

@0xSaurabh
Copy link
Contributor

I have tested this item ✅ successfully on 5abcc46


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877.

@brianteeman
Copy link
Contributor

You should also look at other uses of bg-white and review if they are needed

@Quy
Copy link
Contributor Author

Quy commented Mar 26, 2021

@brianteeman This is the only instance.

@brianteeman
Copy link
Contributor

build\media_source\templates\atum\js\template.es6.js

@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Mar 26, 2021
@Quy
Copy link
Contributor Author

Quy commented Mar 26, 2021

Thanks. Please retest.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on c851260


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877.

1 similar comment
@0xSaurabh
Copy link
Contributor

I have tested this item ✅ successfully on c851260


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877.

@Quy Quy removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Mar 26, 2021
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Mar 26, 2021
@Quy
Copy link
Contributor Author

Quy commented Mar 26, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32877.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 26, 2021
@Quy Quy added this to the Joomla 4.0 milestone Mar 26, 2021
@chmst chmst merged commit 27351c6 into joomla:4.0-dev Mar 27, 2021
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Mar 27, 2021
@chmst
Copy link
Contributor

chmst commented Mar 27, 2021

Thanks!

@Quy Quy deleted the remove-bg-white branch March 27, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants