[4.0] FTP error message #33123
Closed
[4.0] FTP error message #33123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message displayed when the ftp username/password fail is in a different voice (style) to that of other messages.
Quy
reviewed
Apr 13, 2021
| @@ -74,7 +74,7 @@ JLIB_CACHE_ERROR_CACHE_STORAGE_LOAD="Unable to load Cache Storage: %s" | |||
|
|
|||
| JLIB_CAPTCHA_ERROR_PLUGIN_NOT_FOUND="Captcha plugin not set or not found. Please contact a site administrator." | |||
|
|
|||
| JLIB_CLIENT_ERROR_HELPER_SETCREDENTIALSFROMREQUEST_FAILED="Looks like User's credentials are no good." | |||
| JLIB_CLIENT_ERROR_HELPER_SETCREDENTIALSFROMREQUEST_FAILED="The ftp credentials are not correct." | |||
There was a problem hiding this comment.
Maybe use incorrect like the following:
INSTL_DATABASE_INVALID_DB_DETAILS="The database details provided are incorrect and/or empty."
There was a problem hiding this comment.
@Quy 's suggestion seems to be better just "ftp credentials" instead of "database details" may sound a bit better
Quy
reviewed
Apr 15, 2021
| @@ -74,7 +74,7 @@ JLIB_CACHE_ERROR_CACHE_STORAGE_LOAD="Unable to load Cache Storage: %s" | |||
|
|
|||
| JLIB_CAPTCHA_ERROR_PLUGIN_NOT_FOUND="Captcha plugin not set or not found. Please contact a site administrator." | |||
|
|
|||
| JLIB_CLIENT_ERROR_HELPER_SETCREDENTIALSFROMREQUEST_FAILED="Looks like User's credentials are no good." | |||
| JLIB_CLIENT_ERROR_HELPER_SETCREDENTIALSFROMREQUEST_FAILED="The ftp credentials are not correct." | |||
There was a problem hiding this comment.
Suggested change
| JLIB_CLIENT_ERROR_HELPER_SETCREDENTIALSFROMREQUEST_FAILED="The ftp credentials are not correct." | |
| JLIB_CLIENT_ERROR_HELPER_SETCREDENTIALSFROMREQUEST_FAILED="The FTP credentials are not correct." |
|
When a decision is made about ftp i will update this |
This comment was marked as abuse.
This comment was marked as abuse.
|
closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message displayed when the ftp username/password fail is in a different voice (style) to that of other messages.