Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] update cacert.pem #33518

Merged
merged 1 commit into from
May 3, 2021
Merged

[4.0] update cacert.pem #33518

merged 1 commit into from
May 3, 2021

Conversation

brianteeman
Copy link
Contributor

replaces a 4 year old cert with the latest one available from http://curl.haxx.se/ca/cacert.pem

replaces a 4 year old cert with the latest one available from http://curl.haxx.se/ca/cacert.pem
@wilsonge wilsonge merged commit 37e143e into joomla:4.0-dev May 3, 2021
@wilsonge
Copy link
Contributor

wilsonge commented May 3, 2021

Thanks!

@wilsonge
Copy link
Contributor

wilsonge commented May 3, 2021

If you want a small task. We're shipping with the composer ca bundle module (https://github.com/composer/ca-bundle ) anyhow which ships the mozilla CA. We can add an explicit dependency on it and just use the CaBundle::getBundledCaBundlePath() to avoid us having to update this (given we're not very good at updating it) and reduce duplicated files in the CMS

@brianteeman
Copy link
Contributor Author

Thanks for the merge. I will look at the task later

@brianteeman brianteeman deleted the cacert branch May 4, 2021 07:34
@regularlabs
Copy link
Contributor

Joomla 4 uses the ca-bundle cacert.pem (/libraries/vendor/composer/ca-bundle/res/cacert.pem)
This now causes issues with servers using updated Let's Encrypt certificates.

See: https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/
and https://medium.com/geekculture/will-you-be-impacted-by-letsencrypt-dst-root-ca-x3-expiration-d54a018df257

This also concerns Joomla 3 setups!

@brianteeman
Copy link
Contributor Author

see #34703

@regularlabs
Copy link
Contributor

Thanks

@wojsmol
Copy link
Contributor

wojsmol commented Oct 7, 2021

@brianteeman @wilsonge Certificate merged with this PR contains DST Root CA X3 expired Let's Encrypt Root certificate - this will cause issues on openssl version 1.0.2 - see Old Let’s Encrypt Root Certificate Expiration and OpenSSL 1.0.2

@regularlabs
Copy link
Contributor

Also something half-related... if I update my Joomla 4 setup to the nightly build, I still don't get a libraries/src/Http/Transport/cacert.pem file.
All that Transport folder contains is:
image

So I guess there is something wrong in the Joomla 4 update process that doesn't add this file when it isn't there...
🤷🏻‍♂️

@regularlabs
Copy link
Contributor

And just to make clear what the effects of this issue are:
Currently all Joomla websites trying to 'Find updates' to extensions hosted on servers with updated Let's Encrypt certificates (like mine) will get error messages, stating they can't connect to the update site.
image

This is of course a serious issue. So I assume that Joomla will release new versions asap that fix this.

@brianteeman
Copy link
Contributor Author

probably best to create a new issue - not many people like me are subscribed to all messages

@wojsmol
Copy link
Contributor

wojsmol commented Oct 7, 2021

We have a 2 issues here. I can create one related to expired Let's Encrypt root certificate.

@wojsmol
Copy link
Contributor

wojsmol commented Oct 7, 2021

@regularlabs PR for 3.10 #35781 - partial as in is 3.10 we have separate copy in composer/ca-bundle witch is a dependency of joomla/http.
For 4.0-dev and up we use composer/ca-bundle directly -see #34697.

@regularlabs
Copy link
Contributor

Awesome. Thanks. Hopefully, Joomla will release new versions asap to deal with this global issue that now affects millions.

@wojsmol
Copy link
Contributor

wojsmol commented Oct 8, 2021

AFAIK we will be faster then CMS with name starting with W.

@regularlabs
Copy link
Contributor

Wix?

@wojsmol
Copy link
Contributor

wojsmol commented Oct 8, 2021

@regularlabs We both know a connect name :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants