Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Atum] joomla-alert.scss oddly located #33552

Closed
ciar4n opened this issue May 4, 2021 · 3 comments
Closed

[Atum] joomla-alert.scss oddly located #33552

ciar4n opened this issue May 4, 2021 · 3 comments
Labels
No Code Attached Yet

Comments

@ciar4n
Copy link
Contributor

ciar4n commented May 4, 2021

https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/joomla-custom-elements/joomla-alert.scss

This file exists in the Atum template but only ever used in the installation template.
@dgrammatiko
Copy link
Contributor

It’s also used in atum

@brianteeman
Copy link
Contributor

where?

@dgrammatiko
Copy link
Contributor

Here:

joomla-cms/layouts/joomla/system/message.php

Line 45 in 4ca2231

->useStyle('webcomponent.joomla-alert')

This line calls the media/vendor/joomla-custom-elements/css/joomla-alert.css but since there is an override (it's how Joomla IS supposed to work correctly) in administrator/templates/atum/css/vendor/joomla-custom-elements/joomla-alert.css the system will load that file instead...

@ciar4n ciar4n closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brianteeman @ciar4n @dgrammatiko @joomla-cms-bot