Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remove hr in frontend edit module #34044

Closed
wants to merge 1 commit into from
Closed

[4.0] Remove hr in frontend edit module #34044

wants to merge 1 commit into from

Conversation

rjharishabh
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Remove <hr> in the frontend edit module

Testing Instructions

Try to edit module in frontend
edit

Actual result BEFORE applying this Pull Request

hr-before

Expected result AFTER applying this Pull Request

hr-after

Documentation Changes Required

No

@brianteeman
Copy link
Contributor

The line is there intentionally as a separator between different parts of the form

@rjharishabh
Copy link
Contributor Author

The line is there intentionally as a separator between different parts of the form

Is it necessary to separate this way?
I don't think so

@chmst
Copy link
Contributor

chmst commented May 22, 2021

@rjharishabh I agree that the hr looks more like a bug than a feature ;)

Have you an idea for grouping the input fields?

@brianteeman
Copy link
Contributor

it will of course depend on the template as well

@rjharishabh
Copy link
Contributor Author

Sorry for the late reply
Is it really necessary to group
there is no grouping required between position and status (should be similar to backend)
And the note is a text field and options is an accordion (IMO it's already separated)

I don't know much about design

@ghost
Copy link

ghost commented May 24, 2021

I have tested this item ✅ successfully on 7936469


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34044.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 7936469


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34044.

@rdeutz
Copy link
Contributor

rdeutz commented May 30, 2021

the hr looks odd but removing it is not the right way because we loosing the separation in the backend

@rdeutz rdeutz closed this May 30, 2021
@rjharishabh
Copy link
Contributor Author

@rdeutz this is for frontend.

@chmst
Copy link
Contributor

chmst commented May 30, 2021

@rjharishabht this whole layout needs some work. Thank you for opening this PR anyway, this was really useful, as obviously the layout was not properly analysed before.

@rjharishabh
Copy link
Contributor Author

@rjharishabht this whole layout needs some work. Thank you for opening this PR anyway, this was really useful, as obviously the layout was not properly analysed before.

Got it
Thanks

@rjharishabh rjharishabh deleted the frontend-hr branch May 30, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants