-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Remove hr in frontend edit module #34044
Conversation
The line is there intentionally as a separator between different parts of the form |
Is it necessary to separate this way? |
@rjharishabh I agree that the hr looks more like a bug than a feature ;) Have you an idea for grouping the input fields? |
it will of course depend on the template as well |
Sorry for the late reply I don't know much about design |
I have tested this item ✅ successfully on 7936469 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34044. |
1 similar comment
I have tested this item ✅ successfully on 7936469 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34044. |
the hr looks odd but removing it is not the right way because we loosing the separation in the backend |
@rdeutz this is for frontend. |
@rjharishabht this whole layout needs some work. Thank you for opening this PR anyway, this was really useful, as obviously the layout was not properly analysed before. |
Got it |
Pull Request for Issue # .
Summary of Changes
Remove
<hr>
in the frontend edit moduleTesting Instructions
Try to edit module in frontend
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No