Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] com_admin typos #34454

Merged
merged 3 commits into from Jun 7, 2021
Merged

[4.0] com_admin typos #34454

merged 3 commits into from Jun 7, 2021

Conversation

brianteeman
Copy link
Contributor

code review

@ChristineWk
Copy link

Not sure, but could you check line 4379 again pls?
All others seems OK.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34454.

@brianteeman
Copy link
Contributor Author

line 4379?

what word

@ChristineWk
Copy link

saw still this: '/media/editors/codemirror/theme/darcula.css'
But I'm going to bed now :-)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34454.

@brianteeman
Copy link
Contributor Author

your patch is out of date. I removed dracula and darcula

@Quy Quy added this to the Joomla 4.0 milestone Jun 7, 2021
@Quy Quy merged commit 90d49ae into joomla:4.0-dev Jun 7, 2021
@Quy
Copy link
Contributor

Quy commented Jun 7, 2021

Thanks!

@brianteeman
Copy link
Contributor Author

thank you

@brianteeman brianteeman deleted the com_admin branch June 8, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla 4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brianteeman @ChristineWk @Quy @joomla-cms-bot