User selector is blank by default #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User selector displays "Select a User" when you explicitly clear the selection by pressing the button "- No User -", but it is blank by default.
Hot to reproduce the problem: Go to USer > User Notes and create a new note. The User ID field is blank. Click on the blue button in order to select an user. Once arrived on the users list click on "No USer" button. The users list disappears, but this time the USer ID field contains the text "Select a User".
Source file: libraries/cms/form/field/user.php
Since JText::_('JLIB_FORM_SELECT_USER') is not a valid username, it's clear that the original code wanted to assign JText::_('JLIB_FORM_SELECT_USER') to $table->name instead of $table->username.
|
Hi @demis-palma confirm issue and fix Good catch! |
|
@demis-palma can you send the same against the 2.5.x branche and link at the Tracker? |
brianteeman
added
Has JoomlaCode Tracker Item
and removed
Needs JoomlaCode Tracker Item
labels
infograf768
added a commit
that referenced
this pull request
Apr 16, 2014
User selector is blank by default
Bakual
pushed a commit
to Bakual/joomla-cms
that referenced
this pull request
May 12, 2014
User selector is blank by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User selector displays "Select a User" when you explicitly clear the selection by pressing the button "- No User -", but it is blank by default.
How to reproduce the problem: Go to User > User Notes and create a new note. The User ID field is blank. Click on the blue button in order to select an user. Once arrived on the users list click on "No User" button. The users list disappears, but this time the User ID field contains the text "Select a User".
Source file: libraries/cms/form/field/user.php
Since JText::('JLIB_FORM_SELECT_USER') is not a valid username, it's clear that the original code wanted to assign JText::('JLIB_FORM_SELECT_USER') to $table->name instead of $table->username.