Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#33000] Fixed Purge cache button not working because of a missing form #3479

Closed
wants to merge 5 commits into from
Closed

Conversation

roland-d
Copy link
Contributor

@roland-d roland-d changed the title Fixed Purge cache button not working because of a missing form [#33000] Fixed Purge cache button not working because of a missing form Apr 20, 2014
@@ -1296,6 +1296,8 @@ $ -> Language fix or change
28-Apr-2013 Jean-Marie Simonet
$ Adding installation languages : ro-RO and gd-GB

JM: Testing committing to staging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this is supposed to be here :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it doesn't belong there but I don't know how it got in there nor do I know how to remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is likely based on a wrong branch or something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I remove this CHANGELOG file from the PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easiest is to just delete those two lines from the file and commit it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The easiest way was to checkout the file from the 3-3-dev branch and then
amend & force push to update PR
On 21 Apr 2014 09:41, "RolandD" notifications@github.com wrote:

In installation/CHANGELOG:

@@ -1296,6 +1296,8 @@ $ -> Language fix or change
28-Apr-2013 Jean-Marie Simonet
$ Adding installation languages : ro-RO and gd-GB

+JM: Testing committing to staging

How do I remove this CHANGELOG file from the PR?

Reply to this email directly or view it on GitHubhttps://github.com//pull/3479/files#r11803584
.

@infograf768
Copy link
Member

Indeed...

@roland-d
Copy link
Contributor Author

Closing this since it's a big mess.

@roland-d roland-d closed this Apr 22, 2014
@roland-d
Copy link
Contributor Author

The new PR can be found here:
#3490

@roland-d roland-d deleted the 33000 branch April 22, 2014 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants