Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J4 RC5 a11y - increae color contrast for drop down #35010

Open
coolcat-creations opened this issue Aug 1, 2021 · 10 comments
Open

J4 RC5 a11y - increae color contrast for drop down #35010

coolcat-creations opened this issue Aug 1, 2021 · 10 comments

Comments

@coolcat-creations
Copy link
Contributor

Steps to reproduce the issue

grafik

grafik

The color contrast in the green drop downs is not enough

Expected result

White and a darker green would work
grafik

Actual result

Contrast Checker fails

System information (as much as possible)

Joomla 4 RC5 and Firefox Developer Edition

@brianteeman
Copy link
Contributor

I'm a bit confused - which green are you referring to. If it is the green box with the black indicator then you cut the graphic before it shows the relevant part ;)

image

If its the green text on the white background then it is also fine

image

@coolcat-creations
Copy link
Contributor Author

I tested the black chevron on the green and It shows both fail in the color contrast checker?

@chmst
Copy link
Contributor

chmst commented Aug 1, 2021

The black chevron on dark green indeed has bad contrast.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35010.

@chmst chmst added the a11y Accessibility label Aug 1, 2021
@brianteeman
Copy link
Contributor

It is not text. It's a user interface component which as shown in the screenshot passes because the contrast only needs to be 3:1

@coolcat-creations
Copy link
Contributor Author

Ok, got you - however the contrast is so weak that it confused even me and I am not color blind. this could be optimized or not?

@coolcat-creations coolcat-creations changed the title J4 RC5 a11y - color contrast for drop down J4 RC5 a11y - increae color contrast for drop down Aug 1, 2021
@brianteeman
Copy link
Contributor

The problem is that because of the strange way the arrow has been created that has to stay as black and changing the green is the only option but that has a knock on effect throughout the template.

For me the only real solution is to fix the way the arrow is created

@coolcat-creations
Copy link
Contributor Author

coolcat-creations commented Aug 2, 2021

Seems we could change the css to

.form-select.form-select-success, .form-select.form-select-danger { background-image: url("/administrator/templates/atum/images/select-bg-white.svg"); }

and add a white arrow svg.

I am currently with the Joomla Kids Training and not able to do the PR but hopefully next week if no one has time to do it.

Or someone could fix the strange markup that is done there...

@Krshivam25
Copy link
Contributor

I'm working on this issue. Thanks

@Quy
Copy link
Contributor

Quy commented Aug 3, 2021

Is it necessary to have the color background? Maybe resurrect this PR #28755

@Krshivam25
Copy link
Contributor

Krshivam25 commented Aug 3, 2021

Is it necessary to have a color background? Maybe resurrect this PR #28755

Maybe not as another tab is having white color background.
color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants