Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla 4 RC5 - Target Position unclear description #35025

Open
coolcat-creations opened this issue Aug 2, 2021 · 9 comments
Open

Joomla 4 RC5 - Target Position unclear description #35025

coolcat-creations opened this issue Aug 2, 2021 · 9 comments

Comments

@coolcat-creations
Copy link
Contributor

What needs to be fixed

There is a setting named Target Position in the menu module and it's absolutely not clear what it does. Maybe someone could rewrite to the description below where Popups could appear.

grafik

Why this should be fixed

to avoid confusion

How would you fix it

Someone could rewrite the description to explain what it does

@brianteeman
Copy link
Contributor

This is exactly the same as in Joomla 3 except that the description is not hidden.

I have read and read that description multiple times now and I cant see how it could be any clearer

JavaScript values to position a popup window, eg top=50, left=50, width=200, height=300.

@ChristineWk
Copy link

I have also read and read - and don't know :-)
Maybe: To position JavaScript values of a popup window, e.g. ...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35025.

@coolcat-creations
Copy link
Contributor Author

Ok, fun - never knew there is a popup window anywhere - what Popup window?

@brianteeman
Copy link
Contributor

brianteeman commented Aug 3, 2021

Try it and see. It might be so old that it doesnt do anything at all

@brianteeman
Copy link
Contributor

If the menu type is URL and the target is New Window without navigation then the settings here determine the size of the new window

@coolcat-creations
Copy link
Contributor Author

Thank you! So its the setting for a new window and not for a popup? Maybe we could write it like that in the description?
Or rename the setting in the Menu to Popup instead of New Window?

@brianteeman
Copy link
Contributor

  1. we're in language freeze so nothing can be changed right now
  2. personally I wouldnt bother to change it in the future. its probably been this way since the stone age

@chmst
Copy link
Contributor

chmst commented Aug 5, 2021

Personally I would remove the param. I never tried but can this be accessible?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35025.

@brianteeman
Copy link
Contributor

Personally I would remove the param. I never tried but can this be accessible?

It can be if someone wanted it to.

Too late to remove it now though for 4.0

@Hackwar Hackwar added the bug label Feb 22, 2023
@brianteeman brianteeman added the a11y Accessibility label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants