[#33661] Missing form field attribute "maxlength".

[todordev]

This patch adds the attribute "maxlength" to the form field "textarea".

Joomla!Code Tracker Page:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33661

[Achal-Aggarwal]

we should not use !empty with maxlength here. If we do we couldn'y set maxLength=0.
use isset in setup method and assign false to maxLength if it is not set. Check rows & columns attributes.

[todordev]

I see. I just use the code from the form field "text".
The purpose is to be similar with the code of the "text" field.
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/form/fields/text.php

I do not want to change the code of the person, which has done the project “Improve Form Fields”. :)
So, I will let you do it if you want. :)

[Achal-Aggarwal]

LOL, I did that project. If you want I can edit both fields and maybe look others also for similar issues. What you say?

[todordev]

That will be great! :)
If you want, you can add other attributes.

• placeholder
• form
• selectionDirection
• selectionEnd
• selectionStart
• wrap

Check Valentin's replay on Joomla!Code Tracker Page 33661.

[wilsonge]

placeholder is there. Just it's been called hint

[Robdebert]

" All is well — The Travis CI build passed " <- is there anything still left open? I refer to this: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33661 where Valentin says, that not enough testing was done and so it does not get implemented in the next version(s)

if you need more code-reviews / testing, i'll be happy to help.

[Bakual]

Travis is the automated testing. It can detect some code errors, but doesn't detect every error.
We always need manual testing for things to get merged. Usually at least two successful tests should be logged in the issue tracker (http://issues.joomla.org) before something is considered "ready to commit". From there someone will review the code and merge it.

[isidrobaq]

I tested the proposed patch, and worked as described for me. So here's a "successful test" for this one :).

What's the status for this issue? Maybe would be able to do it into 3.4 if another successful test comes?

Thanks!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3510.}

[infograf768]

as stated above this needs some small improvements

[zero-24]

@ITPrism can you implement the changes that was suggsested by @Achal-Aggarwal in the inline comments? So we can move this forward? Thanks 😄

[ghost]

I think this issue is fixed already by RTC PR #6460 that will be applied in J!3.5.0

[wilsonge]

I have merged #6460. If there are any futher issues can you open a new PR please?