Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing labels on filter fields #35682

Closed
wants to merge 1 commit into from
Closed

Conversation

VP-Joomla
Copy link

https://issues.joomla.org/tracker/joomla-cms/2699
The reported issue is still reproducable on joomla 3.10.1.
A fix had been added to J4 but missing from J3.

<span class="visually-hidden"><?php echo $field->label; ?></span>

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Check the issue.
https://issues.joomla.org/tracker/joomla-cms/2699

Actual result BEFORE applying this Pull Request

Labels were not visible of search filters

Expected result AFTER applying this Pull Request

Shows labels of search filters

Documentation Changes Required

No

@ghost
Copy link

ghost commented Oct 24, 2021

I have tested this item 🔴 unsuccessfully on 3a9e55c

Labels show Constant, not Text:

35682


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35682.

@VP-Joomla
Copy link
Author

I have tested this item red_circle unsuccessfully on 3a9e55cLabels show Constant, not Text:

35682
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35682.

It seems that the lang strings are not translated.

image

@infograf768
Copy link
Member

infograf768 commented Oct 28, 2021

These strings were never created. This was committed on Oct 18, 2013.

See efa2ed4#diff-4c9206d6fa23c1923ba2b27fc70d29462279f1867d910b9656d8758518d95ec4

In J4, the labels have been changed.

@Quy Quy added the JBS label Feb 5, 2022
@zero-24
Copy link
Contributor

zero-24 commented Jun 12, 2022

will close here for the points done by JM above.

@zero-24 zero-24 closed this Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants