Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Invisible recaptcha label #35814

Closed
brianteeman opened this issue Oct 12, 2021 · 3 comments
Closed

[4.0] Invisible recaptcha label #35814

brianteeman opened this issue Oct 12, 2021 · 3 comments

Comments

@brianteeman
Copy link
Contributor

Steps to reproduce the issue

Configure and enable the invisible recaptcha plugin

Expected result

Contact form is displayed with the invisible recaptcha and the label is not displayed

Actual result

Label is displayed
image

System information (as much as possible)

cassiopeia
current main branch

Additional comments

@C-Lodder
Copy link
Member

libraries/src/Form/Field/CaptchaField.php

Adding protected $hiddenLabel = true; to the field doesn't work, for some odd reason.
Only way I managed to hide it, was by adding an empty protected function getLabel() {}, but not sure this is the correct approach.

@joomdonation
Copy link
Contributor

Change https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/captcha/recaptcha_invisible/recaptcha_invisible.php#L172 to

$element['hiddenLabel'] = 'true';

should solve the issue.

@joomdonation
Copy link
Contributor

I made PR #35834 to fix this issue. Please check and give feedback. Closing this issue for now and will re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants