Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import RSS feed issue in Joomla 3.x #36120

Closed
arlexwong opened this issue Nov 26, 2021 · 4 comments
Closed

Import RSS feed issue in Joomla 3.x #36120

arlexwong opened this issue Nov 26, 2021 · 4 comments

Comments

@arlexwong
Copy link

arlexwong commented Nov 26, 2021

Steps to reproduce the issue

This issue happens when the 3rd party component uses Joomla simplepie library and PHP 8.

JoomlaFolder/libraries/vendor/simplepie/simplepie/library/SimplePie/Parse/Date.php
LINE 544 and 545

0 implode(): Argument # 2 ($array) must be of type ?array, string given

		$this->day_pcre = '(' . implode(array_keys($this->day), '|') . ')';
		$this->month_pcre = '(' . implode(array_keys($this->month), '|') . ')';

Expected result

PHP syntax error

  • implode(separator,array)

Actual result

It works fine in PHP 5.x and PHP 7.x except PHP 8.

System information (as much as possible)

Joomla 3.10.3, PHP 8

Additional comments

@brianteeman
Copy link
Contributor

Looks like a problem upstream in simplepie https://github.com/simplepie/simplepie/issues

@zero-24
Copy link
Contributor

zero-24 commented Nov 26, 2021

We are shipping an outdated and by the core unused lib here. Within the core we IIRC use our own Feed lib for now. We can not upgrade to the latest version because of the php version supported by J3. J4 does no longer ship with this lib.

So i guess we have to build another backport repo and try to make it compatible with php8.. or mark it as known behavior when that is not possible.

@zero-24
Copy link
Contributor

zero-24 commented Nov 26, 2021

Ok looks like there is still a 1.3 branch that supports php 5.3, but I'm not sure whether they still support that branch in the meaning of doing releases. I have just done a PR + that question lets see what they say: simplepie/simplepie#702

@zero-24
Copy link
Contributor

zero-24 commented Dec 20, 2021

Hi @arlexwong please test: #36358

@zero-24 zero-24 closed this as completed Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants