Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility button does not appear (at least) on Safari 15 on MacOS 12 Monterey #36311

Closed
woluweb opened this issue Dec 14, 2021 · 23 comments · Fixed by #38009
Closed

Accessibility button does not appear (at least) on Safari 15 on MacOS 12 Monterey #36311

woluweb opened this issue Dec 14, 2021 · 23 comments · Fixed by #38009

Comments

@woluweb
Copy link

woluweb commented Dec 14, 2021

Steps to reproduce the issue

This refers to https://www.facebook.com/groups/joomlanospam/posts/10158088758700997/
As can be seen on https://www.whatt.eu/en/ the accessibility button (bottom left, just above the cookie button, does appear on all browsers except (at least) on Safari 15 on MacOS 12 Monterey

See the Facebook thread for more screenshots and feedbacks

@TLWebdesign
Copy link

The accessibility javascript tries to load the material icons. On safari for some reason it can't and then loads an alternative which has the transparent background on an emoticon instead of the default material icon.

This is the console message:
[Warning] Accessibility: Material Icons font was not loaded, using emojis instead (accessibility.min.js, line 1:2860)

Seem JS can't add the stylesheet to the page and that check fails so it adds a backup that is not styled correctly.

Kind regards,
Tom

@infograf768
Copy link
Member

OS Monterey

Firefox
Screenshot 2021-12-15 at 07 31 13

Safari 15

Screenshot 2021-12-15 at 07 31 47

Therefore missing not only the font family (Material Icons) but also background colour and the font is set to Italic

@brianteeman
Copy link
Contributor

It's all the same issue. Will pr later today

@brianteeman
Copy link
Contributor

ranbuch/accessibility#24

@infograf768
Copy link
Member

infograf768 commented Dec 16, 2021

Simplest way to solve the issue in the js is correcting the error:

It should be fontFamily:"Material+Icons", and not fontFamily:"Material Icons",

@infograf768
Copy link
Member

ranbuch/accessibility#27

@brianteeman
Copy link
Contributor

I think you are confused between fontFamily and fontFaceSrc

@infograf768
Copy link
Member

I think you are confused between fontFamily and fontFaceSrc

Nope. The js contains both loading the font family and a redundant font-family for the css.
Deleting that second one also corrects the issue as the family is already defined. I just added the + to simplify.

@angieradtke
Copy link
Contributor

angieradtke commented Dec 16, 2021

Hi Guys,
It take a closer look at this plugin and its code today. The idea behind is great, but the HTML-output should be changed.
The reason is the accessibility itself:

  • <i> for the icons should be changed to native buttons.
  • The google icon font should be replaced by svg-icons,
  • The reset button has to become more clear for better understanding
  • Close und reset button should be semantically at the and of the wrapping <div>

Maybe it is something for @dgrammatiko
I can do the icons

@brianteeman
Copy link
Contributor

All of that must be made upstream

@angieradtke
Copy link
Contributor

what do you mean - at ranbuch account?

@angieradtke
Copy link
Contributor

https://github.com/angieradtke/Accessibility-plugin-icons/blob/main/README.md

@bembelimen
Copy link
Contributor

The google icon font should be replaced by svg-icons,

The important thing is to get rid of Google fonts at all, as we have a GDPR problem here in Europe with Joomla! otherwise (or opt-in at least)

@brianteeman
Copy link
Contributor

@angieradtke these changes can only be made upstream at ranbuch.

@angieradtke
Copy link
Contributor

Benjamin told be we forked it already

@bembelimen
Copy link
Contributor

Benjamin told be we forked it already

Sorry I was wrong, I thought about another script there

@angieradtke
Copy link
Contributor

I think needed changes are so massiv that a fork could make sence @dgrammatiko @chmst

@Orgoth
Copy link

Orgoth commented Jan 31, 2022

The google icon font should be replaced by svg-icons,

The important thing is to get rid of Google fonts at all, as we have a GDPR problem here in Europe with Joomla! otherwise (or opt-in at least)

I don't know who downvoted this comment, but for german users without an annoying cookie-consent, using this plugin is not possible.
With the new law ttdsg, the users needs to consent before any request to google or other non european country is allowed.
The use of svg icons or a minimal font-icon-set from icomoon local hosted, would be the perfect solution.

https://www.gesetze-im-internet.de/ttdsg/
https://rewis.io/urteile/urteil/2tj-01-12-2021-6-l-73821wi/
https://rewis.io/urteile/urteil/lhm-20-01-2022-3-o-1749320/

@brianteeman
Copy link
Contributor

Among other things this is resolved by #36948

@woluweb
Copy link
Author

woluweb commented Feb 16, 2022

I have migrated 6 sites from 4.0 to 4.1.
They now all have the following error in the Console:

Uncaught (in promise) DOMException: Failed to execute 'check' on 'FontFaceSet': Could not resolve '1em Material+Icons' as a font.
    at i (https://www.___.be/media/vendor/accessibility/js/accessibility.min.js?3.0.15:1:2738)
    at https://www.___.be/media/vendor/accessibility/js/accessibility.min.js?3.0.15:1:2786

The Accessibility button looks fine (with the wheelchair icon), but when opening it all icons there are broken.

NB: in the meatime I see this issue had just been reported (with a fix mentioned by @brianteeman) : #37050

@brianteeman
Copy link
Contributor

Its because the change made in the script was wrong and merged even though I stated several times it was wrong :(

@drmenzelit drmenzelit added the a11y Accessibility label Mar 26, 2022
@brianteeman
Copy link
Contributor

see #38009

@alikon
Copy link
Contributor

alikon commented Jun 8, 2022

please test #38009

@alikon alikon closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.