Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Changed blog modifiers on Cassiopeia #36998

Merged
merged 2 commits into from Feb 23, 2022

Conversation

drmenzelit
Copy link
Contributor

Pull Request for Issues found by @woluweb
https://slides.woluweb.be/cassiopeia/cassiopeia.html#5-2-issue-2-the-read-more-button-partially-hidden
https://slides.woluweb.be/cassiopeia/cassiopeia.html#5-3-issue-3-layout-in-blog-view

Summary of Changes

Changed the _modifiers.scss file and added a media query for the code that controls the display of image and content on blog layout with images positioned left (image-left) or right (image-right) or alternating (image-alternate).

Testing Instructions

Create some articles with intro images and read more, at least one article with a very short text. Create a menu item of type category blog and use the classes image-left, image-right alone and in combination with image-alternate

Actual result BEFORE applying this Pull Request

See issues description on the links above
On mobiles: Read more buttons are not displaying completely, too much space between image and content, images over and below the text (by using class image-alternate)

Screenshot 2022-02-10 at 18-36-08 Blog

On desktops: By short text the position of the images is weird

Screenshot 2022-02-10 at 18-44-27 Blog

Expected result AFTER applying this Pull Request

Buttons are ok, no space between image and content, no weird distribution of image and content. Using image-alternate the image will display always on top of the article on mobiles

Screenshot 2022-02-10 at 19-33-31 Blog

Screenshot 2022-02-10 at 18-48-47 Blog

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Feb 10, 2022
@drmenzelit drmenzelit changed the title Changed blog modifiers [4.1] Changed blog modifiers on Cassiopeia Feb 10, 2022
@woluweb
Copy link

woluweb commented Feb 11, 2022

I have tested this item ✅ successfully on f984443

Txs very much for taking the time of this PR @drmenzelit !
Tested successfully during our tests/exchanges yesterday on Glip on my own J4 site in construction.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36998.

@RickR2H
Copy link
Member

RickR2H commented Feb 11, 2022

I have tested this item ✅ successfully on f984443


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36998.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester Frontend Template labels Feb 11, 2022
@RickR2H
Copy link
Member

RickR2H commented Feb 11, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36998.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 11, 2022
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Feb 23, 2022
@laoneo laoneo merged commit a079d0f into joomla:4.1-dev Feb 23, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 23, 2022
@laoneo
Copy link
Member

laoneo commented Feb 23, 2022

Thanks!

@laoneo laoneo added this to the Joomla 4.1.1 milestone Feb 25, 2022
@drmenzelit drmenzelit deleted the cassiopeia-modifiers branch June 28, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants