[4.1] Changed blog modifiers on Cassiopeia #36998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issues found by @woluweb
https://slides.woluweb.be/cassiopeia/cassiopeia.html#5-2-issue-2-the-read-more-button-partially-hidden
https://slides.woluweb.be/cassiopeia/cassiopeia.html#5-3-issue-3-layout-in-blog-view
Summary of Changes
Changed the _modifiers.scss file and added a media query for the code that controls the display of image and content on blog layout with images positioned left (image-left) or right (image-right) or alternating (image-alternate).
Testing Instructions
Create some articles with intro images and read more, at least one article with a very short text. Create a menu item of type category blog and use the classes
image-left
,image-right
alone and in combination withimage-alternate
Actual result BEFORE applying this Pull Request
See issues description on the links above
On mobiles: Read more buttons are not displaying completely, too much space between image and content, images over and below the text (by using class
image-alternate
)On desktops: By short text the position of the images is weird
Expected result AFTER applying this Pull Request
Buttons are ok, no space between image and content, no weird distribution of image and content. Using
image-alternate
the image will display always on top of the article on mobilesDocumentation Changes Required