Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] search with images broken #37448

Closed
brianteeman opened this issue Apr 1, 2022 · 4 comments
Closed

[4.1] search with images broken #37448

brianteeman opened this issue Apr 1, 2022 · 4 comments

Comments

@brianteeman
Copy link
Contributor

Steps to reproduce the issue

Set up finder to include images when you do a search (follow the instructions in the original PR for this #35612 by @sakiss )

Expected result

If present then images will be displayed in the results

Actual result

The images can never be displayed because it is checking for a variable, $images, which is never set.

This was broken by #37022 by @dgrammatiko

@sakiss
Copy link
Contributor

sakiss commented Apr 1, 2022

You need to clear your indexes and re-index your content.
The images are being indexed like the other variables.

If this does not work, probably it's broken by another PR

@brianteeman
Copy link
Contributor Author

If this does not work, probably it's broken by another PR

That is exactly what I wrote!!

@sakiss
Copy link
Contributor

sakiss commented Apr 1, 2022

Confirmed
I tried in the same site before and after the J update.

@dgrammatiko
Copy link
Contributor

Test #37450

@Quy Quy closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants