[bug] Fix - Email copy to own address doesn't work since 2.5.21

[Kubik-Rubik]

Related to
[bug] [33848] Fix fatal error when sending contact form (#3763)

How to test

• Use Joomla! version 2.5.22 and create a contact - set a link to the contact with a form in the menu
• Fill out the form with some sample data (but correct email address), activate the checkbox "Send copy to yourself" and click on send
• You will never receive a copy of this email because the value of this checkbox input field is empty
• Add patch and try it again

[Kubik-Rubik]

JoomlaCode entry: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33860

[zero-24]

@Kubik-Rubik i can confirm the issue and the fix 👍

[Bakual]

I'm thinking that we should just revert the actual check in the controller and fix it there. It's not necessary a given that any contact form uses JForm to create that checkbox.
HTML Checkboxes are a funny thing. The value of the checkbox actually doesn't matter at all. You have to check if they are submitted, not if they contain a value. The value is only relevant if you have multiple checkboxes with the same name.
On a sidenote, that's actually done wrong in 3.x as well...

[Kubik-Rubik]

@Bakual

I think that a value parameter should be used in a checkbox field and so we can use this solution to fix the bug!

Yes, we could also only optimize the if statement. Instead of checking !empty($data['contact_email_copy']) we could just check whether this request variable is set at all isset($data['contact_email_copy']). If the checkbox is selected, then the request variable is set with an empty value. With the current check this can never be true without providing a value. In Joomla! 3.x the value is set to 1, so the initial fix does work there.

[roland-d]

Just before I test, should I test the value 1 or the proposed controller change? Confused.

[Bakual]

I would use isset personally. Mainly because we don't really know where the form is coming from. It may well be an override (or even a module) which doesn't use JForm and thus would still be broken.
I don't want to risk another broken thing :)
The XML change can of course be kept as well. It's always better :)

[Kubik-Rubik]

@Bakual Correct, updated the PR.
@roland-d Now you can test the whole PR. :-) Thanks!

[roland-d]

@test: After applying the patch, I do get a copy of the message sent via the contact form.

JC tracker moved to RTC.

[Bakual]

Merged with 09e8d05