Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Fix TinyMCE height for multiple editor instances #37964

Merged
merged 2 commits into from Jun 5, 2022

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jun 2, 2022

Summary of Changes

Fix TinyMCE height for multiple editor instances.
This a little thing that misses after #37603 to make Height work correctly.

Testing Instructions

Apply patch, create multiple editor instances somwhere, example add in mod_custom:

<field type="editor" name="editor1" label="Editor 1" height="300"/>
<field type="editor" name="editor2" label="Editor 2" height="800"/>

And edit mod_custom content.

Actual result BEFORE applying this Pull Request

Main editor height: 550 (default, from plugin)
Editor 1 height: 550
Editor 2 height: 550

Expected result AFTER applying this Pull Request

Main editor height: 550 (default, from plugin)
Editor 1 height: 300
Editor 2 height: 800

Documentation Changes Required

none

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 3f81350


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37964.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 5, 2022

I have tested this item ✅ successfully on 3f81350


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37964.

@Quy
Copy link
Contributor

Quy commented Jun 5, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37964.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 5, 2022
@laoneo
Copy link
Member

laoneo commented Jun 5, 2022

Would be good if we have also one test which does the instructions from #37603 just to be sure there is no regression.

@Fedik
Copy link
Member Author

Fedik commented Jun 5, 2022

@laoneo it covered by current test instructions, you can check and will see 😉

@laoneo
Copy link
Member

laoneo commented Jun 5, 2022

Not all of them. Like the editor instance.

@Fedik
Copy link
Member Author

Fedik commented Jun 5, 2022

All of them

@bembelimen bembelimen merged commit c698359 into joomla:4.1-dev Jun 5, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 5, 2022
@bembelimen
Copy link
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants