Replaced inline JavaScript in wrapper #3849
Conversation
| } | ||
| } | ||
| </script> | ||
| <script src="../media/mod_wrapper/js/iframe-height.min.js"></script> |
There was a problem hiding this comment.
Please use the API to load scripts so they can potentially be overridden by templates.
Michael did an excellent blog post once on how to use the API. See http://www.babdev.com/blog/139-use-the-media-folder-allow-overridable-media
|
Making use of JHtml::script(). I'm still confused if mod_wrapper is the best location, because the same script is also used by com_wrapper. |
Joomla will load the min version. WHen debug is turned on, it will load the uncompressed version. So both files are needed.
Personally I would put it into the component location when it's used for both a component and a module. |
J0WI
force-pushed
the
patch-4
branch
2 times, most recently
from
8ac9888
to
201206e
Compare
See #3838
Not sure if media/mod_wrapper is a good location for shared scripts. Alternative?