-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
psr12 script #38754
Comments
I think the psr12 can be removed at some point (will do this later, because it also removes the jexec die). |
its not the only file. i did a grep for tabs in *.php and that gave me 76 files |
yes I understood that, more interesting is why drone doesn't complain. |
drone doesnt complain about a lot of things. I keep saying that |
yes but it should complain about tabs |
thinking out loud here but its almost as if - there were no other errors in the file - so it was skipped. and that the conversion from tab to space only takes place on saving an edited file |
shouldn't be the case because phpcs did the analyse which should know the difference between space and tabs ;-) |
unlikely as this is one of the other files |
see #39145 |
Following a comment elsehwere I checked and there appear to be approx 70 files still using tabs for indentation instead of spaces.
For example
administrator\components\com_actionlogs\src\View\Actionlogs\HtmlView.php
I ran the psr12 scripts but it didnt pick up anything and I checked the ruleset.xml to make sure that these files were not being excluded.
@HLeithner am I missing something?
The text was updated successfully, but these errors were encountered: