[4.2] npm: fix bootstrap to version 5.1.3 #38803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
1 task
|
If you change it to ~5.1.3 then if they ever release further patches in the 5.1 tre would we get those |
|
Agree here with @brianteeman. At least to patch releases of 5.1 should be fine to upgrade. |
|
I'm going to pin it to 5.1 for now. I will leave it to someone else to decide if the update to 5.2 is B/C and to do the work necessary to update our backend template to work with that new version. |
|
Merging it for now. But we really need to look into the update issue for bootstrap 5.2. Thanks for this @Hackwar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Right now, when we simply run npm update, npm tries to update bootstrap to version 5.2, which doesn't work. Right now we can't update to more than 5.1.3. This pins the package to that version.