-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F10 is mentioned as fullscreen toggle; should be F11. #40255
Comments
Closing as not an issue for reason stated. |
Thank you Brian for explaining. I tried to find any document about CODEMIRROR and FULL SCREEN annd this came up: @Quy I would appreciate to be able to close MY issue after I am satisfied with the response. |
Thank you again. There is still so much to discover in Joomla! This is the perfect solution. I would not mind if this became the default... 😃 |
Steps to reproduce the issue
Making an override in i.e. the template presents the codemirror as editor. Here the F10 is mentioned to switch to full screen.
Expected result
Advise the F11 as this works in a.o. Chrome and Firefox
Actual result
F10 is advised and does not work.
System information (as much as possible)
Joomla 4 current version
Additional comments
I changed my local version:
Solution:
plugins/editors/codemirror/layouts/editors/codemirror/element.php
line 32 $fskeys[] = $params->get('fullScreen', 'F10');
changed to
line 32 $fskeys[] = $params->get('fullScreen', 'F11');
The text was updated successfully, but these errors were encountered: