[4.4] Fix a11y issue in accordion #40572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obuisard
requested review from
laoneo,
bembelimen,
HLeithner,
zero-24,
rdeutz,
Hackwar,
fancyFranci and
wilsonge
as code owners
obuisard
changed the title
obuisard
changed the title
|
Closing this in favour to a PR on 4.3. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
The issue was mentioned in JAT channel by @rytechsites. Thanks for reporting.
Summary of Changes
This PR removes the role attribute from bootstrap accordion. Thanks @drmenzelit.
Testing Instructions
Add a few page breaks into an article, set the layout in the page break plugin to "slider".
Check the result with an a11y tool.
Similar for menu item types modal or other occurrences of accordions
Actual result BEFORE applying this Pull Request
You will get a11y issues for the role attribute.
Expected result AFTER applying this Pull Request
No a11y issues.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed