Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatal upgrading from 3.1 to 3.2 in some cases #4096

Closed
wants to merge 1 commit into from

Conversation

wilsonge
Copy link
Contributor

Fatal error: Call to a member function isAdmin() on a non-object in xxx/plugins/system/remember/remember.php on line 42

Found when upgrading a site from 3.1 to 3.2

@Bakual
Copy link
Contributor

Bakual commented Aug 11, 2014

Sounds quite similar to #3467
😄

I was never able to verifiy the PR because I can't reproduce the issue on my server. Were you able to reproduce it?

@wilsonge
Copy link
Contributor Author

Nope. Jacques contacted me on skype about it. I'll close it in favour of yours then

@wilsonge wilsonge closed this Aug 11, 2014
@wilsonge wilsonge deleted the patch-5 branch August 11, 2014 13:07
@wilsonge
Copy link
Contributor Author

He also said it's all across the forums

@Bakual
Copy link
Contributor

Bakual commented Aug 11, 2014

Yep, it's raised often, and I even got a logfile from someone. But nobody was able to test the PR and confirm if the issue is solved.
I guess we just have to merge the PR and see if it fixes the issue this way. It can't break anything imho.

@wilsonge
Copy link
Contributor Author

I agree. I think it's one of these ones where we've applied the fix in other plugins so we just merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants