Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix to fix double slash in helpsite url Issue #2701 #4143

Closed
wants to merge 1 commit into from

Conversation

purplebeanie
Copy link
Contributor

Hi Folks

A very, very small fix for Issue #2701 as reported by @lahmizzar.

Just starting to get my toes wet with contributing to Joomla via Github so I hope I have done this properly?

Cheers,
Eric.

@Bakual
Copy link
Contributor

Bakual commented Aug 22, 2014

The PR is fine. If you can add test instructions it will be perfect. Thank you!

@purplebeanie
Copy link
Contributor Author

Great thanks.

###Test instructions###

To test login in to Joomla admin and from top menu bar select the Edit Account under the gear icon.

Click the "Refresh" button next to Help Site with Chrome Dev tools or Firebug open. The URL for the XHR should only have one "/" before the index.php.... rather than the double slash as reported in the original ticket.

4143-testing-success

@ghost
Copy link

ghost commented Aug 22, 2014

Just applied patch and followed test instructions, but the refresh button doesn't seem to do anything now. The console doesn't populate the expected URL.
no-result

@purplebeanie
Copy link
Contributor Author

Hi @sonkoral .... Thansk for testing.

Okay, it looks like you actually have logging of XMLHTTPRequests turned off. On Chrome you need to turn it on separately.

To turn logging of XMLHTTPRequests on click on the little cog icon on the top right of developer tools. Go to General under the Settings on the left and click General (it should open by default). The on the right hand side at the bottom make sure the Log XMLHttpRequests box is checked.
doubleslash-2

Cheers,
Eric.

@brianteeman
Copy link
Contributor

@test
After enabling XMLHTTPRequests logging I could see the // and can confirm that the patch resolves this

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

@ghost
Copy link

ghost commented Aug 24, 2014

Thanks for the pointer in Firebug! Confirmed patch eliminates the double slashes as well.

@brianteeman
Copy link
Contributor

2 good tests setting RTC

@Bakual Bakual closed this in 7c183c1 Aug 24, 2014
@Bakual
Copy link
Contributor

Bakual commented Aug 24, 2014

Merged, thanks!

@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants