Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: email cloaking does not work with & in text to 2.5.x #4274

Merged
merged 2 commits into from
Sep 15, 2014
Merged

Backport: email cloaking does not work with & in text to 2.5.x #4274

merged 2 commits into from
Sep 15, 2014

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Sep 12, 2014

Please see the orginal issue for 3.x (#4263) and the PR against staging (#4273)

The same issue is in 2.5.x and the same fix work good for me.

As the code is by @heleneross i mark my test as the first successful test. The PR against staging was by @n9iels Thank you guys.

Please see the orginal issue for 3.x (#4263) and the PR (#4273)

The same issue is in 2.5.x and the same fix work good for me.

Sinze the code is not from me i mark the first successful test.
@n9iels
Copy link
Contributor

n9iels commented Sep 12, 2014

@test works fine for me and solves the bug

@zero-24
Copy link
Contributor Author

zero-24 commented Sep 12, 2014

thanks @n9iels i moving this to RTC as the code comes from @heleneross

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

@infograf768
Copy link
Member

@zero-24
I had to correct code style for 3.x
Can you do here too?
Space after coma: $text = htmlentities($text,ENT_QUOTES,'UTF-8',false);

@jissues-bot jissues-bot added the RTC This Pull Request is Ready To Commit label Sep 14, 2014
@zero-24
Copy link
Contributor Author

zero-24 commented Sep 14, 2014

done @infograf768

infograf768 added a commit that referenced this pull request Sep 15, 2014
Backport: email cloaking does not work with & in text to 2.5.x
@infograf768 infograf768 merged commit 5e9a0be into joomla:2.5.x Sep 15, 2014
@zero-24 zero-24 deleted the patch-14 branch September 15, 2014 08:18
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants