Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] cpanel card border in dark mode #43158

Open
Razzo1987 opened this issue Mar 26, 2024 · 3 comments
Open

[5.1] cpanel card border in dark mode #43158

Razzo1987 opened this issue Mar 26, 2024 · 3 comments

Comments

@Razzo1987
Copy link
Contributor

Steps to reproduce the issue

the size of the Dashboard Panels is different between light and dark mode;

image
image

(in the first case you can read the text)

Expected result

same height

Actual result

different height

Additional comments

the reason is a border on dark mode:
image

which adds a minimum of separation from the background (the colors are too dark), but which change the size from the light

@brianteeman
Copy link
Contributor

Not sure I see the problem you are describing.

@Razzo1987
Copy link
Contributor Author

in the homepage check the position of the lowest element on the page as you change from dark to light mode.
It moves down a few pixels in dark mode because Dashboard Panels in dark mode have a border of 1 pixel.

Removing the border makes it unusable (the colors were made darker, although I think we had rejected that choice), but leaving it makes the elements move....

@brianteeman
Copy link
Contributor

personaly not worried about a pixel shift here.

@Hackwar Hackwar added the bug label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants