[fix] error when adding tags with keyboard. Fixes #4394 #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@test: After applying the patch, I can save the article after adding a tag using Enter. |
|
Fixed via 9da927e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in:
#4394
This was introduced in: 88ed53e#diff-0fe9e3814af6ea886d29a21726738a2aR166
Apparently minTermLength fix from @davidhurley's didn't include a default value for the setting. So it was using 0 as minimum length (until you save the
com_paramsconfig). I added an extrathis.valuecheck to be sure that an empty tag is never going to be added even if someone manages to use 0 asminTermLength(which should not be possible because the minimum in config is 1).