Changed Autosuggester #4401

tkempf · 2014-09-30T12:54:32Z

Change Autosuggester so that it respects static-filters,accesslevels,publish up/down dates and article states
This code is not yet production ready but runs fine for me on a site with Joomla 2.5.17 since 2 years

mbabker · 2014-09-30T13:21:02Z

components/com_finder/models/suggestions.php

@@ -61,17 +61,106 @@ protected function getListQuery()
 	{
 		// Create a new query object.
 		$db = $this->getDbo();
+		//attempt to change mysql for error in large select
+		$db->setQuery('SET SQL_BIG_SELECTS=1');


Can you wrap this in a $db->name check so that the non-MySQL databases will still at least attempt to work with this?

zero-24 · 2014-10-01T08:39:50Z

@tkempf please notice that travis is not happy with your code:


FILE: ...is/build/joomla/joomla-cms/components/com_finder/models/suggestions.php

--------------------------------------------------------------------------------

FOUND 19 ERROR(S) AND 4 WARNING(S) AFFECTING 18 LINE(S)

--------------------------------------------------------------------------------

  68 | ERROR   | Whitespace found at end of line

  77 | ERROR   | Whitespace found at end of line

  86 | ERROR   | Whitespace found at end of line

  87 | WARNING | Expected 1 space after "="; 0 found

  87 | ERROR   | Expected 1 space before "="; 0 found

  94 | WARNING | Expected 1 space after ".="; 0 found

  94 | ERROR   | Expected 1 space before ".="; 0 found

  95 | WARNING | Expected 1 space after "<"; 0 found

  95 | ERROR   | Expected 1 space before "<"; 0 found

  96 | WARNING | Expected 1 space after ".="; 0 found

  96 | ERROR   | Expected 1 space before ".="; 0 found

  98 | ERROR   | No space found after comma in function call

 101 | ERROR   | Whitespace found at end of line

 105 | ERROR   | Whitespace found at end of line

 109 | ERROR   | Functions and classes must not contain multiple empty lines in

     |         | a row; found 2 empty lines

 113 | ERROR   | No space found after comma in function call

 114 | ERROR   | No space found after comma in function call

 115 | ERROR   | No space found after comma in function call

 115 | ERROR   | No space found after comma in function call

 116 | ERROR   | Whitespace found at end of line

 118 | ERROR   | Whitespace found at end of line

 120 | ERROR   | Whitespace found at end of line

 161 | ERROR   | Whitespace found at end of line

--------------------------------------------------------------------------------


FILE: ...home/travis/build/joomla/joomla-cms/modules/mod_finder/tmpl/default.php

--------------------------------------------------------------------------------

FOUND 2 ERROR(S) AFFECTING 1 LINE(S)

--------------------------------------------------------------------------------

 130 | ERROR | Concat operator must be followed by one space

 130 | ERROR | Concat operator must be preceeded by one space

--------------------------------------------------------------------------------

see: https://travis-ci.org/joomla/joomla-cms/jobs/36741145

static-filters,accesslevels,publish up/down dates and article states

mysqli databases

code

pjmatos · 2015-04-13T01:51:04Z

I'm testing this in J3.4.1 and it is working okay.
Thanks, tkempf.

kathastaden · 2015-08-21T08:50:23Z

I tested with version: Joomla 3.4.4-dev development

Enable the Smart Search Plugin
Go to the Smart Search Component and click "Index" to get some results
Have a look at the Frontend and the Smart Search module and test the autosuggestion there
Search for an article that is unpublished - with the patch this one should not be suggested anymore
Search for an article that will be published in future - with the patch this one should not be suggested anymore
Search for an article that is only for Super Users and you are not logged in at the Frontend - with the patch this one should not be suggested anymore
Create a Search Filter and use the Smart Search of the Frontend to find it

Result: After I applied the patch, the whole suggestions in the Smart Search didn't work anymore. As an example I searched for "similar" because there is an article called "Similar Tags" and this one should be suggested.
I attached a screenshot of the suggestion before the patch was applied, and after it was applied.

Before the Patch was applied:

After the Patch was applied:

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4401.}

hitchblade · 2015-08-21T11:34:22Z

Using Joomla Version : 3.4.4-dev.
Enable Smart Search Plugin. Tested a while. After I applied the Plugin and go to my smartsearch in the Frontend, I get a blank Page...

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4401.}

zero-24 · 2015-08-23T09:10:43Z

@tkempf can you try to get the code working on the current staging? Based on the last tests it don't work. Please add a comment if you have find the issue. Thanks.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4401.}

parameter f in the serviceurl otherwise

plugin seems not to change the state of the finder item after changing the article state

default_form and omit the parameter f in the serviceurl otherwise

tkempf · 2015-08-26T06:11:37Z

code is now working again on current staging. There was an issue when no filter was selected. Can you pls. reopen.
While testing i found that the content - finder plugin does not reflect state changes in the search index items. IMO disabling an article should disable the corresponding search index item. Pls. correct me if i am wrong...

date and end date filters

adriano-paula-ribeiro · 2015-09-05T00:33:33Z

I confirm patch this one should not be suggested anymore.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4401.}

brianteeman · 2016-05-08T14:33:52Z

Thank you for creating this but it would appear that this has been resolved elsewhere in the code base. If this is not correct then this can be re-opened

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4401.}

Giuse69 · 2016-05-25T22:29:20Z

I just tested on J3.5.1 and autosuggester does not respect for example access level: as a guest I get a suggestion for a Administrator level article, so it is not resolved in codebase?

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4401.}

Quy · 2018-05-31T02:33:44Z

@brianteeman Should this be closed too as unfixable per #16011?

jissues-bot added the PR-staging label Sep 30, 2014

tkempf mentioned this pull request Sep 30, 2014

Smart search showing unpublished articles in auto suggest #4301

Closed

mbabker reviewed Sep 30, 2014
View reviewed changes

tkempf force-pushed the autosuggester branch from 0a2320d to 35d98e0 Compare December 1, 2014 08:47

tkempf added 5 commits March 10, 2015 14:27

Change Autosuggester so that it respects

0c0f96d

static-filters,accesslevels,publish up/down dates and article states

Check that the SQL_BIG_SELECTS query will only be executed on mysql and

9a9ab49

mysqli databases

Use method chaining for query building

3a70094

Revert field selection including language filtering to current master

d853256

code

To make travis happy

e390b02

tkempf force-pushed the autosuggester branch from 35d98e0 to e390b02 Compare March 12, 2015 11:16

tkempf added 2 commits March 12, 2015 13:14

Some more codestyle changes after rebasing onto current codebase

5d927f0

Some more codestyle changes after rebasing onto current codebase

cc08f65

zero-24 closed this Aug 23, 2015

tkempf added 5 commits August 24, 2015 08:57

Merge remote-tracking branch 'upstream/staging' into autosuggester

b8002e8

Merge remote-tracking branch 'upstream/staging' into autosuggester

5f2085e

Check if a static filter is used for autosuggestions and omit the

7adc050

parameter f in the serviceurl otherwise

check for publish state in autosuggester query, as the finder-content

346ace7

plugin seems not to change the state of the finder item after changing the article state

Check if a static filter is used for autosuggestions in the components

0d7649f

default_form and omit the parameter f in the serviceurl otherwise

zero-24 reopened this Aug 26, 2015

tkempf added 3 commits August 26, 2015 10:31

Codestyle changes

7b8f848

Codestyle changes

b149b50

Move Init Code from getListQuery() to populateState(). Add the start

9330622

date and end date filters

tkempf added 3 commits August 27, 2015 10:18

Correct access to searchfilter-params in search results form view

daed030

Codestyle changes

d72731e

Codestyle changes

2f872f3

This was referenced Jan 15, 2016

Smart Search - search suggestion does not obey access permission of content #8655

Closed

Smart Search - show result without rights #8901

Closed

brianteeman closed this May 8, 2016

brianteeman reopened this Mar 25, 2018

ggppdk mentioned this pull request May 24, 2018

[com_finder] Problem with suggestions #16011

Closed

brianteeman closed this May 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed Autosuggester #4401

Changed Autosuggester #4401

tkempf commented Sep 30, 2014 •

edited by brianteeman

mbabker Sep 30, 2014

tkempf Oct 1, 2014

zero-24 commented Oct 1, 2014

pjmatos commented Apr 13, 2015

kathastaden commented Aug 21, 2015

hitchblade commented Aug 21, 2015

zero-24 commented Aug 23, 2015

tkempf commented Aug 26, 2015

adriano-paula-ribeiro commented Sep 5, 2015

brianteeman commented May 8, 2016

Giuse69 commented May 25, 2016

Quy commented May 31, 2018

Changed Autosuggester #4401

Changed Autosuggester #4401

Conversation

tkempf commented Sep 30, 2014 • edited by brianteeman

mbabker Sep 30, 2014

Choose a reason for hiding this comment

tkempf Oct 1, 2014

Choose a reason for hiding this comment

zero-24 commented Oct 1, 2014

pjmatos commented Apr 13, 2015

kathastaden commented Aug 21, 2015

hitchblade commented Aug 21, 2015

zero-24 commented Aug 23, 2015

tkempf commented Aug 26, 2015

adriano-paula-ribeiro commented Sep 5, 2015

brianteeman commented May 8, 2016

Giuse69 commented May 25, 2016

Quy commented May 31, 2018

tkempf commented Sep 30, 2014 •

edited by brianteeman