Fix renderModules error when getTemplate called with true from included module templates #4421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getTemplate(true) is called from a module override (i.e. to retrieve template params), JModuleHelper renderModules method breaks because the $template variable's value has changed from a string (the name of the template) to an object (holding the template's params) between being assigned and when actually called. This is due to module overrides being called after the variable has been assigned a value but before it is used by the chrome and attribs vars.
Instead of assigning to a $template var, getTemplate is called directly to ensure the template name is available rather than the stdClass.