[Code Style] Line exceeds 150 characters; contains 181 characters #4487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
testrun for codesprint this weekend with newlysetup laptop |
| @@ -31,7 +31,8 @@ public static function clients() | |||
|
|
|||
| // Create the batch selector to change the client on a selection list. | |||
| $lines = array( | |||
| '<label id="batch-client-lbl" for="batch-client" class="hasTooltip" title="' . JHtml::tooltipText('COM_BANNERS_BATCH_CLIENT_LABEL', 'COM_BANNERS_BATCH_CLIENT_LABEL_DESC') . '">', | |||
| '<label id="batch-client-lbl" for="batch-client" class="hasTooltip" title="' | |||
| . JHtml::tooltipText('COM_BANNERS_BATCH_CLIENT_LABEL', 'COM_BANNERS_BATCH_CLIENT_LABEL_DESC') . '">', | |||
There was a problem hiding this comment.
Should both lines not be indented? Even better maybe to add each option on a new line like this:
'<label
id="batch-client-lbl"
for="batch-client"
class="hasTooltip"
....
Anyone else has any thoughts on this? Is there anything in the styleguide regarding this other than just line length?
|
This has been fixed with #4515 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Code Style] Line exceeds 150 characters; contains 181 characters