Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variable $row in frontend com_tags #4623

Closed
javigomez opened this issue Oct 12, 2014 · 6 comments
Closed

Undefined variable $row in frontend com_tags #4623

javigomez opened this issue Oct 12, 2014 · 6 comments

Comments

@javigomez
Copy link
Contributor

While fixing Code Style issues I found this undefined variable $row at:

components/com_tags/views/tag/view.feed.php on line 74

looks like wrong variable name. See https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/views/tags/view.feed.php#L74

@joomdonation
Copy link
Contributor

There are several reasons causing this issue:

  1. The wrong variable name as you said: $row should be replaced by $item
  2. The getListQuery method of TagsModelTags class doesn't return author, author_email, fields, so it will throw warning in other line code as well : https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/views/tags/view.feed.php#L56
  3. The code in this line will also throw warning as there is no displayDate returned for each item https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/views/tags/view.feed.php#L57

I can make a PR to fix these issues (it is quite easy). However, do you know how we can see there warnings (so that I can give testing instructions in the pull require) ? Is there an easy way to show these warnings ?

@joomdonation
Copy link
Contributor

OK. I went ahead to make pull request to fix this issue #4651 (and several issues I found as well). Please help testing it :)

@aDaneInSpain
Copy link
Contributor

Why does this not have the PR-staging tag?

@joomdonation
Copy link
Contributor

Sorry. I deleted the original repo which I made the PR. I think that's the reason :(.

@Hackwar
Copy link
Member

Hackwar commented Dec 4, 2014

Since we have #4651 to fix this, I'm going to close this issue report.

@jissues-bot
Copy link

Set to "closed" on behalf of @Hackwar by The JTracker Application at issues.joomla.org/joomla-cms/4623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants