Add trigger to com_content front category model #4656
Conversation
|
Good innovation. Allows you to expand the use of com_content. |
|
Please have a look at #4308 which tries to unify plugin triggers. |
Arkadiy-Sedelnikov
changed the title
|
See "MiniCCK Filter" on this page http://demoj3.argens.ru/index.php/blog |
|
Hello @Arkadiy-Sedelnikov Thank you for your contribution. The last comment here was on 25th November. So the question is, Is this issue/pull request still valid? Does the PR linked by Bakual solve the issue? If no reply is received within 4 weeks we will close this issue. Thanks for understanding! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4656. |
|
I already solved the problem of the absence of the trigger in my extension substitution model. All it'd be better if the trigger was in the home model, but the urgent need for this anymore. |
| @@ -239,6 +239,12 @@ function getItems() | |||
| $model->setState('filter.max_category_levels', $this->getState('filter.max_category_levels')); | |||
| $model->setState('list.links', $this->getState('list.links')); | |||
|
|
|||
| $dispatcher = JEventDispatcher::getInstance(); | |||
| // Include the content plugins for the change of category state event | |||
There was a problem hiding this comment.
Please fix the comment as it is not a change of category state event.
|
I'm confused on what exactly this is supposed to be doing. |
|
Testing the trigger was successful. The trigger calls the function "onGetContentItems" for a content plugin like "contact". |
|
See http://demoj3.argens.ru/index.php/blog |
|
I get that the trigger is added and running. What I don't get is why it's being added and what the purpose is for this very specific use case. Generally, we do not have event triggers to manipulate an object (model or database query typically) before a data query is executed; this changes that behavior for one very exclusive use case. Right now this PR looks to me like a "I need this feature for my extension so I'm going to add it without anymore detail" situation and my inclination is to suggest it be closed because of that (looks to be something for an edge case in an extension and no clarifying explanation about why this is proposed). IMO, this PR needs to be better explained; why is this event trigger needed for only this one use case out of all the components shipped with the Joomla core. |
|
I wrote that for my extension this PR is not mandatory, I already made a spoof of this model with a built-in trigger. The trigger I use for content filtering ин additional fields on my CCK, so it can use other CCK parasitic on com_content. |
|
I'm closing this PR as in the current state it will not get merged. To many questions are open. If we want to introduce this new plugin event, it should better be placed in a library model somewhere so it's triggered for all extensions, not a single one. |
Trigger a need for content filtering.