Weblink Module not appearing in front-end; Weblink menu item shows as "unpublished"

[adrianfso]

Steps to reproduce the issue

Create Weblink items in the backend, ensuring they're set to published in any category. Create a new module of "Weblinks" type, ensuring the category and a valid position are selected.

In addition, create a new menu item of the "Weblinks" type (single category display).

Expected result

The module should appear on all pages in the selected position.

In addition, the menu item created should also display the category of Weblinks as published.

Actual result

The position seems to be rendered, but the content is not.

In addition, the menu item does display the Weblinks, but a tag called "unpublished" appears on the page. "Unpublished" appears whether or not the user is signed into the front-end.

System information (as much as possible)

MSSQL, IIS, J!3.3.6

Additional comments

There seems to be an issue with the "publish" calculations. Also, there aren't any files in the "components/weblinks/views/weblink/tmpl/" folder (other than index.html). Is that supposed to be empty?

[adrianfso]

Got it working. It's because DATE_FORMAT is not recognized in MSSQL. Instead, converting to date format is required.

Here's the proposed fix... but only applies to ms-sql:

\modules\mod_weblinks\helper.php
line 85
'a._, c.published AS c_published,' . $case_when1 . ',' . $case_when2 . ',' . 'convert(char(10), a.created, 120) AS created_date'

_This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4657.*

[nicksavov]

Thanks Adrian! Could you submit a pull request for it? Here's a really easy way how:
http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

[Bakual]

Please make sure the PR is actually done in the new repo for weblinks here: https://github.com/joomla-extensions/weblinks

[brianteeman]

Closing here as the PR was created against the weblinks repo - thanks joomla-extensions/weblinks#16

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4657.}