Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing language string #4677

Merged
merged 3 commits into from
Oct 15, 2014
Merged

missing language string #4677

merged 3 commits into from
Oct 15, 2014

Conversation

brianteeman
Copy link
Contributor

COM_NEWSFEEDS_NUM_ITEMS changed to COM_NEWSFEEDS_NUM_ARTICLES as the language file uses ARTICLES not ITEMS

Before

before

After

after

@infograf768
Copy link
Member

Imho wrong Brian
It should be
COM_NEWSFEEDS_NUM_ITEMS="# of Newsfeeds"

we already have a string for articles, they concerned a single newsfeed as far as I know
COM_NEWSFEEDS_NUM_ARTICLES="# Articles"
COM_NEWSFEEDS_NUM_ARTICLES_COUNT="# Articles: %s"

@brianteeman
Copy link
Contributor Author

My mistake - I will correct the PR

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4677.

@brianteeman
Copy link
Contributor Author

PR updated

@infograf768
Copy link
Member

Simple change. Merged directly in staging as the string is missing.

infograf768 added a commit that referenced this pull request Oct 15, 2014
@infograf768 infograf768 merged commit d0b2c20 into joomla:staging Oct 15, 2014
@brianteeman brianteeman deleted the patch-2 branch October 15, 2014 08:42
@mbabker mbabker added this to the Joomla! 3.3.7 milestone Oct 16, 2014
@mbabker mbabker modified the milestones: Joomla! 3.3.7, Joomla! 3.4.0 Nov 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants